]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
scsi: ufs: exynos: remove tx_dif_p_nsec from exynosauto_ufs_drv_init()
authorPeter Griffin <peter.griffin@linaro.org>
Thu, 31 Oct 2024 15:00:27 +0000 (15:00 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 3 Nov 2024 01:13:01 +0000 (21:13 -0400)
Remove the assignment of tx_dif_p_nsec as both users of
exynosauto_ufs_drv_init() function (exynosauto and gs101) set the
EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR flag meaning that tx_dif_p_nsec has
no effect.

Additionally both users also set the samsung,sysreg dt property, meaning
the execution flow will always return on the regmap_update_bits() call
before the assignment.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20241031150033.3440894-9-peter.griffin@linaro.org
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-exynos.c

index e477ab86e3c15df578c5698f7d583bc0eaad8a3e..378c16d905c11718543e3544c28de62f8df6138c 100644 (file)
@@ -200,8 +200,6 @@ static inline void exynos_ufs_ungate_clks(struct exynos_ufs *ufs)
 
 static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs)
 {
-       struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
-
        /* IO Coherency setting */
        if (ufs->sysreg) {
                return regmap_update_bits(ufs->sysreg,
@@ -209,8 +207,6 @@ static int exynosauto_ufs_drv_init(struct exynos_ufs *ufs)
                                          UFS_SHARABLE, UFS_SHARABLE);
        }
 
-       attr->tx_dif_p_nsec = 3200000;
-
        return 0;
 }