]> www.infradead.org Git - users/hch/misc.git/commitdiff
selftests/futex: Fix format-security warnings in futex_priv_hash
authorNai-Chen Cheng <bleach1827@gmail.com>
Wed, 27 Aug 2025 13:00:09 +0000 (15:00 +0200)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 1 Sep 2025 14:20:08 +0000 (16:20 +0200)
Fix format-security warnings by using proper format strings when passing
message variables to ksft_exit_fail_msg(), ksft_test_result_pass(), and
ksft_test_result_skip() function.

Thus prevent potential security issues and eliminate compiler warnings when
building with -Wformat-security.

Signed-off-by: Nai-Chen Cheng <bleach1827@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/20250827130011.677600-4-bigeasy@linutronix.de
tools/testing/selftests/futex/functional/futex_priv_hash.c

index ec032faca6a91fa712730c7061a41e815b8c5e52..ffd60d03a992b74f72512e2bc3b2839fe1ca5090 100644 (file)
@@ -192,10 +192,10 @@ int main(int argc, char *argv[])
        futex_slots1 = futex_hash_slots_get();
        if (futex_slots1 <= 0) {
                ksft_print_msg("Current hash buckets: %d\n", futex_slots1);
-               ksft_exit_fail_msg(test_msg_auto_create);
+               ksft_exit_fail_msg("%s", test_msg_auto_create);
        }
 
-       ksft_test_result_pass(test_msg_auto_create);
+       ksft_test_result_pass("%s", test_msg_auto_create);
 
        online_cpus = sysconf(_SC_NPROCESSORS_ONLN);
        ret = pthread_barrier_init(&barrier_main, NULL, MAX_THREADS + 1);
@@ -236,11 +236,11 @@ retry_getslots:
                        }
                        ksft_print_msg("Expected increase of hash buckets but got: %d -> %d\n",
                                       futex_slots1, futex_slotsn);
-                       ksft_exit_fail_msg(test_msg_auto_inc);
+                       ksft_exit_fail_msg("%s", test_msg_auto_inc);
                }
-               ksft_test_result_pass(test_msg_auto_inc);
+               ksft_test_result_pass("%s", test_msg_auto_inc);
        } else {
-               ksft_test_result_skip(test_msg_auto_inc);
+               ksft_test_result_skip("%s", test_msg_auto_inc);
        }
        ret = pthread_mutex_unlock(&global_lock);