]> www.infradead.org Git - users/hch/block.git/commitdiff
nvme-pci: remove an extra queue reference
authorChristoph Hellwig <hch@lst.de>
Thu, 29 Sep 2022 07:26:33 +0000 (09:26 +0200)
committerChristoph Hellwig <hch@lst.de>
Mon, 17 Oct 2022 05:00:28 +0000 (07:00 +0200)
Now that blk_mq_destroy_queue does not release the queue reference, there
is no need for a second admin queue reference to be held by the nvme_dev.

Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/pci.c

index 16509b8d92e599a5c78b47989a0428480f41fd3f..efea468a2a5bb89f12d9b683134bfba6f81918c5 100644 (file)
@@ -1749,7 +1749,6 @@ static void nvme_dev_remove_admin(struct nvme_dev *dev)
                 */
                nvme_start_admin_queue(&dev->ctrl);
                blk_mq_destroy_queue(dev->ctrl.admin_q);
-               blk_put_queue(dev->ctrl.admin_q);
                blk_mq_free_tag_set(&dev->admin_tagset);
        }
 }
@@ -1778,11 +1777,6 @@ static int nvme_pci_alloc_admin_tag_set(struct nvme_dev *dev)
                dev->ctrl.admin_q = NULL;
                return -ENOMEM;
        }
-       if (!blk_get_queue(dev->ctrl.admin_q)) {
-               nvme_dev_remove_admin(dev);
-               dev->ctrl.admin_q = NULL;
-               return -ENODEV;
-       }
        return 0;
 }