scsi: lpfc: Treat SCSI Write operation Underruns as an error

Orabug: 27631736

Currently, write underruns (mismatch of amount transferred vs scsi
status and its residual) detected by the adapter are not being flagged
as an error. Its expected the target controls the data transfer and
would appropriately set the RSP values.  Only read underruns are treated
as errors.

Revise the SCSI error handling to treat write underruns as an error as
well.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit 45634a86ca6e98dbcaddb763f8e90ad243057789)
Signed-off-by: Dick dkennedy <dick.kennedy@broadcom.com>
Signed-off-by: Dan Duval <dan.duval@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
index 9a1a2ea5e1235b4f6165122cad7886fba4fc7846..4e9249a9c25c17a35d02b7c2a788e3e3c879f575 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_scsi.c
+++ b/drivers/scsi/lpfc/lpfc_scsi.c
@@ -3770,20 +3770,18 @@ lpfc_handle_fcp_err(struct lpfc_vport *vport, struct lpfc_scsi_buf *lpfc_cmd,
                scsi_set_resid(cmnd, be32_to_cpu(fcprsp->rspResId));
 
                lpfc_printf_vlog(vport, KERN_INFO, LOG_FCP_UNDER,
-                                "9025 FCP Read Underrun, expected %d, "
+                                "9025 FCP Underrun, expected %d, "
                                 "residual %d Data: x%x x%x x%x\n",
                                 fcpDl,
                                 scsi_get_resid(cmnd), fcpi_parm, cmnd->cmnd[0],
                                 cmnd->underflow);
 
                /*
-                * If there is an under run check if under run reported by
+                * If there is an under run, check if under run reported by
                 * storage array is same as the under run reported by HBA.
                 * If this is not same, there is a dropped frame.
                 */
-               if ((cmnd->sc_data_direction == DMA_FROM_DEVICE) &&
-                       fcpi_parm &&
-                       (scsi_get_resid(cmnd) != fcpi_parm)) {
+               if (fcpi_parm && (scsi_get_resid(cmnd) != fcpi_parm)) {
                        lpfc_printf_vlog(vport, KERN_WARNING,
                                         LOG_FCP | LOG_FCP_ERROR,
                                         "9026 FCP Read Check Error "