]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/usb/u2f-passthru: Get rid of qemu_open_old()
authorZhao Liu <zhao1.liu@intel.com>
Mon, 15 Jul 2024 08:21:51 +0000 (16:21 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 17 Jul 2024 11:04:15 +0000 (14:04 +0300)
For qemu_open_old(), osdep.h said:

> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".

So replace qemu_open_old() with qemu_open().

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/usb/u2f-passthru.c

index b7025d303d07c817d212b46fef60d5a109768d68..c4a783d128640ae67cfed80e51c14a7193848a85 100644 (file)
@@ -482,10 +482,8 @@ static void u2f_passthru_realize(U2FKeyState *base, Error **errp)
         return;
 #endif
     } else {
-        fd = qemu_open_old(key->hidraw, O_RDWR);
+        fd = qemu_open(key->hidraw, O_RDWR, errp);
         if (fd < 0) {
-            error_setg(errp, "%s: Failed to open %s", TYPE_U2F_PASSTHRU,
-                       key->hidraw);
             return;
         }