]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
can: peak_usb: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 28 Jun 2018 17:41:42 +0000 (12:41 -0500)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 27 Jul 2018 08:40:17 +0000 (10:40 +0200)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/peak_usb/pcan_usb.c
drivers/net/can/usb/peak_usb/pcan_usb_core.c
drivers/net/can/usb/peak_usb/pcan_usb_pro.c

index f530a80f505115675e01cb60223e06016e5e4a9b..13238a72a33862a7c2acfc966c03f93d206d82be 100644 (file)
@@ -423,6 +423,7 @@ static int pcan_usb_decode_error(struct pcan_usb_msg_context *mc, u8 n,
                        new_state = CAN_STATE_ERROR_WARNING;
                        break;
                }
+               /* else: fall through */
 
        case CAN_STATE_ERROR_WARNING:
                if (n & PCAN_USB_ERROR_BUS_HEAVY) {
index 50e9114286380258843fb582e4d1a100a41c743d..611f9d31be5d0370612fe8d4f9771b88dd9f3d37 100644 (file)
@@ -353,6 +353,7 @@ static netdev_tx_t peak_usb_ndo_start_xmit(struct sk_buff *skb,
                default:
                        netdev_warn(netdev, "tx urb submitting failed err=%d\n",
                                    err);
+                       /* fall through */
                case -ENOENT:
                        /* cable unplugged */
                        stats->tx_dropped++;
index 0105fbfea273ad4c874006d72e5c0e94dbfb8b95..d516def846abec6c661dc185da1d64b73ca22441 100644 (file)
@@ -141,8 +141,10 @@ static int pcan_msg_add_rec(struct pcan_usb_pro_msg *pm, u8 id, ...)
        switch (id) {
        case PCAN_USBPRO_TXMSG8:
                i += 4;
+               /* fall through */
        case PCAN_USBPRO_TXMSG4:
                i += 4;
+               /* fall through */
        case PCAN_USBPRO_TXMSG0:
                *pc++ = va_arg(ap, int);
                *pc++ = va_arg(ap, int);