]> www.infradead.org Git - nvme.git/commitdiff
drm/amdgpu: drop redundant cg/pg ungate on runpm enter
authorEvan Quan <evan.quan@amd.com>
Fri, 24 Apr 2020 07:36:22 +0000 (15:36 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 1 May 2020 13:23:49 +0000 (09:23 -0400)
CG/PG ungate is already performed in ip_suspend_phase1. Otherwise,
the CG/PG ungate will be performed twice. That will cause gfxoff
disablement is performed twice also on runpm enter while gfxoff
enablemnt once on rump exit. That will put gfxoff into disabled
state.

Fixes: b2a7e9735ab286 ("drm/amdgpu: fix the hw hang during perform system reboot and reset")
Signed-off-by: Evan Quan <evan.quan@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index 957d4872a85576658cc2c89b71cc98afe23a6ca5..affde2de2a0dbd3f68f934c693ff7a906f9223a7 100644 (file)
@@ -3372,9 +3372,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool fbcon)
                }
        }
 
-       amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);
-       amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE);
-
        amdgpu_ras_suspend(adev);
 
        r = amdgpu_device_ip_suspend_phase1(adev);