]> www.infradead.org Git - mtd-utils.git/commitdiff
mtd-utils: nanddump: fix writing big images on 32bit machines
authorSascha Hauer <s.hauer@pengutronix.de>
Wed, 8 Jun 2022 07:51:14 +0000 (09:51 +0200)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Wed, 8 Jun 2022 07:53:51 +0000 (09:53 +0200)
When writing a full 4GiB NAND to a file end_addr becomes 0x100000000.
With that writing out the first page to the file doesn't happen
because size_left is calculated to 0x100000000 - 0 = 0x100000000
which is then truncated to 32bit and becomes zero. Fix this by
using an appropriate 64bit type for size_left.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
nand-utils/nanddump.c

index d7fc3205750d3d091508e96f15de18f7425d72d1..47539f528aa2d98587b6b8afde340fcfb0def2d3 100644 (file)
@@ -499,7 +499,7 @@ int main(int argc, char * const argv[])
                        }
                } else {
                        /* Write requested length if oob is omitted */
-                       size_t size_left = end_addr - ofs;
+                       long long size_left = end_addr - ofs;
                        if (omitoob && (size_left < bs))
                                err = ofd_write(ofd, readbuf, size_left);
                        else