platform/loongarch: laptop: Unregister generic_sub_drivers on exit

Without correct unregisteration, ACPI notify handlers and the platform
drivers installed by generic_subdriver_init() will become dangling
references after removing the loongson_laptop module, triggering various
kernel faults when a hotkey is sent or at kernel shutdown.

Cc: stable@vger.kernel.org
Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yao Zi <ziyao@disroot.org>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>

diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platform/loongarch/loongson-laptop.c
index 9ba4c06252b623fbe8109455f6036de6ace6522f..61b18ac206c9ee4546450e59b6e35f208812221e 100644 (file)
--- a/drivers/platform/loongarch/loongson-laptop.c
+++ b/drivers/platform/loongarch/loongson-laptop.c
@@ -612,11 +612,17 @@ static int __init generic_acpi_laptop_init(void)
 
 static void __exit generic_acpi_laptop_exit(void)
 {
+       int i;
+
        if (generic_inputdev) {
-               if (input_device_registered)
-                       input_unregister_device(generic_inputdev);
-               else
+               if (!input_device_registered) {
                        input_free_device(generic_inputdev);
+               } else {
+                       input_unregister_device(generic_inputdev);
+
+                       for (i = 0; i < ARRAY_SIZE(generic_sub_drivers); i++)
+                               generic_subdriver_exit(&generic_sub_drivers[i]);
+               }
        }
 }