]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: mii: Fix the Speed display when the network cable is not connected
authorXiangqian Zhang <zhangxiangqian@kylinos.cn>
Fri, 17 Jan 2025 09:46:03 +0000 (17:46 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Jan 2025 20:02:38 +0000 (12:02 -0800)
Two different models of usb card, the drivers are r8152 and asix. If no
network cable is connected, Speed = 10Mb/s. This problem is repeated in
linux 3.10, 4.19, 5.4, 6.12. This problem also exists on the latest
kernel. Both drivers call mii_ethtool_get_link_ksettings,
but the value of cmd->base.speed in this
function can only be SPEED_1000 or SPEED_100 or SPEED_10.
When the network cable is not connected, set cmd->base.speed
=SPEED_UNKNOWN.

Signed-off-by: Xiangqian Zhang <zhangxiangqian@kylinos.cn>
Link: https://patch.msgid.link/20250117094603.4192594-1-zhangxiangqian@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/mii.c

index 22680f47385d50ce07f6935392defb33aed94be0..37bc3131d31a8d46fea9da6619734b496fc6857a 100644 (file)
@@ -213,6 +213,9 @@ void mii_ethtool_get_link_ksettings(struct mii_if_info *mii,
                lp_advertising = 0;
        }
 
+       if (!(bmsr & BMSR_LSTATUS))
+               cmd->base.speed = SPEED_UNKNOWN;
+
        mii->full_duplex = cmd->base.duplex;
 
        ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,