]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: enetc: clean up before returning in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 13 Nov 2024 07:31:25 +0000 (10:31 +0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 15 Nov 2024 03:22:22 +0000 (19:22 -0800)
We recently added this error  path.  We need to call enetc_pci_remove()
before returning.  It cleans up the resources from enetc_pci_probe().

Fixes: 99100d0d9922 ("net: enetc: add preliminary support for i.MX95 ENETC PF")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
Link: https://patch.msgid.link/93888efa-c838-4682-a7e5-e6bf318e844e@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/enetc_vf.c

index d18c11e406fca85721c38d160114798d255b9bd5..a5f8ce576b6e80ed0f396ae7fb200464d90506c2 100644 (file)
@@ -174,9 +174,11 @@ static int enetc_vf_probe(struct pci_dev *pdev,
        si = pci_get_drvdata(pdev);
        si->revision = ENETC_REV_1_0;
        err = enetc_get_driver_data(si);
-       if (err)
-               return dev_err_probe(&pdev->dev, err,
-                                    "Could not get VF driver data\n");
+       if (err) {
+               dev_err_probe(&pdev->dev, err,
+                             "Could not get VF driver data\n");
+               goto err_alloc_netdev;
+       }
 
        enetc_get_si_caps(si);