mtd: rawnand: Avoid a typedef

In new code, the use of typedef is discouraged. Turn this one in the
raw NAND core into a regular enumeration.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-mtd/20200526195633.11543-3-miquel.raynal@bootlin.com

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 8ce31490b9d087bb34bc4be4ad299074b9af8c53..4bf614d4b7eebcf4e5693eade901e69585822708 100644 (file)
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -5099,8 +5099,8 @@ static int of_get_nand_ecc_mode(struct device_node *np)
 
        /*
         * For backward compatibility we support few obsoleted values that don't
-        * have their mappings into nand_ecc_modes_t anymore (they were merged
-        * with other enums).
+        * have their mappings into the nand_ecc_mode enum anymore (they were
+        * merged with other enums).
         */
        if (!strcasecmp(pm, "soft_bch"))
                return NAND_ECC_SOFT;

diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index b0b358908a47b1e230fbbf1706090003d070820b..8f662df02fdd13099128927d21c422d6089ae3a3 100644 (file)
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -83,14 +83,14 @@ struct nand_chip;
 /*
  * Constants for ECC_MODES
  */
-typedef enum {
+enum nand_ecc_mode {
        NAND_ECC_NONE,
        NAND_ECC_SOFT,
        NAND_ECC_HW,
        NAND_ECC_HW_SYNDROME,
        NAND_ECC_HW_OOB_FIRST,
        NAND_ECC_ON_DIE,
-} nand_ecc_modes_t;
+};
 
 enum nand_ecc_algo {
        NAND_ECC_UNKNOWN,
@@ -362,7 +362,7 @@ static const struct nand_ecc_caps __name = {                        \
  * @write_oob: function to write chip OOB data
  */
 struct nand_ecc_ctrl {
-       nand_ecc_modes_t mode;
+       enum nand_ecc_mode mode;
        enum nand_ecc_algo algo;
        int steps;
        int size;

diff --git a/include/linux/platform_data/mtd-davinci.h b/include/linux/platform_data/mtd-davinci.h
index 08e639e047e5e8b844f493c58e3def4aabeff7a4..03e92c71b3faafdaa86977b06ee0f5d12e0d4c2b 100644 (file)
--- a/include/linux/platform_data/mtd-davinci.h
+++ b/include/linux/platform_data/mtd-davinci.h
@@ -68,7 +68,7 @@ struct davinci_nand_pdata {           /* platform_data */
         * Newer ones also support 4-bit ECC, but are awkward
         * using it with large page chips.
         */
-       nand_ecc_modes_t        ecc_mode;
+       enum nand_ecc_mode      ecc_mode;
        u8                      ecc_bits;
 
        /* e.g. NAND_BUSWIDTH_16 */

diff --git a/include/linux/platform_data/mtd-nand-s3c2410.h b/include/linux/platform_data/mtd-nand-s3c2410.h
index deb849bcf0ecb6497a7c3133325488de729177f5..08675b16f9e16995f916d4e46f46b4ba42e96a49 100644 (file)
--- a/include/linux/platform_data/mtd-nand-s3c2410.h
+++ b/include/linux/platform_data/mtd-nand-s3c2410.h
@@ -49,7 +49,7 @@ struct s3c2410_platform_nand {
 
        unsigned int    ignore_unset_ecc:1;
 
-       nand_ecc_modes_t        ecc_mode;
+       enum nand_ecc_mode      ecc_mode;
 
        int                     nr_sets;
        struct s3c2410_nand_set *sets;