]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
driver core: class: Correct WARN() message in APIs class_(for_each|find)_device()
authorZijun Hu <quic_zijuhu@quicinc.com>
Tue, 5 Nov 2024 00:20:23 +0000 (08:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Nov 2024 12:10:43 +0000 (13:10 +0100)
For both API class_for_each_device(const struct class *class, ...) and
class_find_device(const struct class *class, ...), their WARN() messages
prompt @class was not initialized when suffer class_to_subsys(@class)
error, but the error actually means @class was not registered, so these
warning messages are not accurate.

Fix by replacing term initialized with registered within these messages.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241105-class_fix-v1-2-80866f9994a5@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/class.c

index cb5359235c7020cd6b79c4d64c2f894f92352fca..582b5a02a5c410113326601fe00eb6d7231f988f 100644 (file)
@@ -405,7 +405,7 @@ int class_for_each_device(const struct class *class, const struct device *start,
        if (!class)
                return -EINVAL;
        if (!sp) {
-               WARN(1, "%s called for class '%s' before it was initialized",
+               WARN(1, "%s called for class '%s' before it was registered",
                     __func__, class->name);
                return -EINVAL;
        }
@@ -453,7 +453,7 @@ struct device *class_find_device(const struct class *class, const struct device
        if (!class)
                return NULL;
        if (!sp) {
-               WARN(1, "%s called for class '%s' before it was initialized",
+               WARN(1, "%s called for class '%s' before it was registered",
                     __func__, class->name);
                return NULL;
        }