tipc: eliminate KASAN warning

The following warning was reported by syzbot on Oct 24. 2017:
KASAN: slab-out-of-bounds Read in tipc_nametbl_lookup_dst_nodes

This is a harmless bug, but we still want to get rid of the warning,
so we swap the two conditions in question.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
index 2856e19e036e7a5c96adf4371fb84d9fc0055438..b3829bcf63c76224eb7d19de41293d397912dcbd 100644 (file)
--- a/net/tipc/name_table.c
+++ b/net/tipc/name_table.c
@@ -697,7 +697,7 @@ void tipc_nametbl_lookup_dst_nodes(struct net *net, u32 type, u32 lower,
        spin_lock_bh(&seq->lock);
        sseq = seq->sseqs + nameseq_locate_subseq(seq, lower);
        stop = seq->sseqs + seq->first_free;
-       for (; sseq->lower <= upper && sseq != stop; sseq++) {
+       for (; sseq != stop && sseq->lower <= upper; sseq++) {
                info = sseq->info;
                list_for_each_entry(publ, &info->zone_list, zone_list) {
                        if (tipc_in_scope(domain, publ->node))