]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: Intel: Skylake: add an error code check in skl_pcm_trigger
authorSu Hui <suhui@nfschina.com>
Fri, 20 Oct 2023 09:26:20 +0000 (17:26 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 25 Oct 2023 16:21:42 +0000 (17:21 +0100)
skl_decoupled_trigger() can return error code like -EPIPE if failed,
add check for this.

Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20231020092619.210520-1-suhui@nfschina.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-pcm.c

index 9f7b0a944bb13298f239ff9dba6b0bac1671208f..91f1fa24a3f1ef80d332eb694784c65af1b12363 100644 (file)
@@ -518,6 +518,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
                        return ret;
 
                ret = skl_decoupled_trigger(substream, cmd);
+               if (ret < 0)
+                       return ret;
+
                if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) {
                        /* save the dpib and lpib positions */
                        hstream->dpib = readl(bus->remap_addr +