mtd: rawnand: brcmnand: Allow working without interrupts

The BCMA devices include the brcmnand controller but they do not wire up
any interrupt line, allow the main interrupt to be optional and update
the completion path to also check for the lack of an interrupt line.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220107184614.2670254-6-f.fainelli@gmail.com

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 40818c881f08966bc2fecc4630ba0e3abd6dbbb2..08e2acde51331b7f3f48f7d6f16b0f9a0c9b840d 100644 (file)
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -216,7 +216,7 @@ struct brcmnand_controller {
        void __iomem            *nand_base;
        void __iomem            *nand_fc; /* flash cache */
        void __iomem            *flash_dma_base;
-       unsigned int            irq;
+       int                     irq;
        unsigned int            dma_irq;
        int                     nand_version;
 
@@ -1610,7 +1610,7 @@ static bool brcmstb_nand_wait_for_completion(struct nand_chip *chip)
        bool err = false;
        int sts;
 
-       if (mtd->oops_panic_write) {
+       if (mtd->oops_panic_write || ctrl->irq < 0) {
                /* switch to interrupt polling and PIO mode */
                disable_ctrl_irqs(ctrl);
                sts = bcmnand_ctrl_poll_status(ctrl, NAND_CTRL_RDY,
@@ -3144,33 +3144,29 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
        }
 
        /* IRQ */
-       ctrl->irq = platform_get_irq(pdev, 0);
-       if ((int)ctrl->irq < 0) {
-               dev_err(dev, "no IRQ defined\n");
-               ret = -ENODEV;
-               goto err;
-       }
-
-       /*
-        * Some SoCs integrate this controller (e.g., its interrupt bits) in
-        * interesting ways
-        */
-       if (soc) {
-               ret = devm_request_irq(dev, ctrl->irq, brcmnand_irq, 0,
-                                      DRV_NAME, ctrl);
+       ctrl->irq = platform_get_irq_optional(pdev, 0);
+       if (ctrl->irq > 0) {
+               /*
+                * Some SoCs integrate this controller (e.g., its interrupt bits) in
+                * interesting ways
+                */
+               if (soc) {
+                       ret = devm_request_irq(dev, ctrl->irq, brcmnand_irq, 0,
+                                              DRV_NAME, ctrl);
 
-               /* Enable interrupt */
-               ctrl->soc->ctlrdy_ack(ctrl->soc);
-               ctrl->soc->ctlrdy_set_enabled(ctrl->soc, true);
-       } else {
-               /* Use standard interrupt infrastructure */
-               ret = devm_request_irq(dev, ctrl->irq, brcmnand_ctlrdy_irq, 0,
-                                      DRV_NAME, ctrl);
-       }
-       if (ret < 0) {
-               dev_err(dev, "can't allocate IRQ %d: error %d\n",
-                       ctrl->irq, ret);
-               goto err;
+                       /* Enable interrupt */
+                       ctrl->soc->ctlrdy_ack(ctrl->soc);
+                       ctrl->soc->ctlrdy_set_enabled(ctrl->soc, true);
+               } else {
+                       /* Use standard interrupt infrastructure */
+                       ret = devm_request_irq(dev, ctrl->irq, brcmnand_ctlrdy_irq, 0,
+                                              DRV_NAME, ctrl);
+               }
+               if (ret < 0) {
+                       dev_err(dev, "can't allocate IRQ %d: error %d\n",
+                               ctrl->irq, ret);
+                       goto err;
+               }
        }
 
        for_each_available_child_of_node(dn, child) {