]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Heckle gpst_obtain_cookie()
authorDavid Woodhouse <dwmw2@infradead.org>
Tue, 15 Aug 2017 16:24:40 +0000 (17:24 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Tue, 15 Aug 2017 16:24:40 +0000 (17:24 +0100)
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
auth-globalprotect.c

index ca6748cb7bdecebe5f63a0585c0bc104b1545b06..2618f3e1ce20cddef6f126b254f9272d0d4d2ba2 100644 (file)
@@ -381,6 +381,8 @@ int gpst_obtain_cookie(struct openconnect_info *vpninfo)
                /* first try handling it as a gateway, then a portal */
                result = gpst_login(vpninfo, 0);
                if (result == -EEXIST) {
+                       /* XX: Don't we want to start by trying the same username/password the user just
+                          entered for the 'gateway' attempt? */
                        result = gpst_login(vpninfo, 1);
                        if (result == -EEXIST)
                                vpn_progress(vpninfo, PRG_ERR, _("Server is neither a GlobalProtect portal nor a gateway.\n"));