]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/nouveau: remove unused increment in gm200_flcn_pio_imem_wr
authorTimur Tabi <ttabi@nvidia.com>
Wed, 13 Aug 2025 00:10:03 +0000 (19:10 -0500)
committerDanilo Krummrich <dakr@kernel.org>
Mon, 25 Aug 2025 16:09:29 +0000 (18:09 +0200)
The 'tag' parameter is passed by value and is not actually used after
being incremented, so remove the increment.  It's the function that calls
gm200_flcn_pio_imem_wr that is supposed to (and does) increment 'tag'.

Fixes: 0e44c2170876 ("drm/nouveau/flcn: new code to load+boot simple HS FWs (VPR scrubber)")
Reviewed-by: Philipp Stanner <phasta@kernel.org>
Signed-off-by: Timur Tabi <ttabi@nvidia.com>
Link: https://lore.kernel.org/r/20250813001004.2986092-2-ttabi@nvidia.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nvkm/falcon/gm200.c

index b7da3ab44c277d764e7f1551dcccc6232554a385..6a004c6e67425550f90a90f00cfae562ae8ec244 100644 (file)
@@ -103,7 +103,7 @@ gm200_flcn_pio_imem_wr_init(struct nvkm_falcon *falcon, u8 port, bool sec, u32 i
 static void
 gm200_flcn_pio_imem_wr(struct nvkm_falcon *falcon, u8 port, const u8 *img, int len, u16 tag)
 {
-       nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag++);
+       nvkm_falcon_wr32(falcon, 0x188 + (port * 0x10), tag);
        while (len >= 4) {
                nvkm_falcon_wr32(falcon, 0x184 + (port * 0x10), *(u32 *)img);
                img += 4;