Address static analysis warning

openssl.c:2090:3: warning: The 1st argument to 'close' is <= -2 but should be >= -1 [unix.StdCLibraryFunctions]
 2090 |                 closesocket(vpninfo->ssl_fd);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
./openconnect-internal.h:1176:21: note: expanded from macro 'closesocket'
 1176 | #define closesocket close
      |                     ^

Signed-off-by: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

diff --git a/openssl.c b/openssl.c
index 4a3663236319eba0c592f630deb3d68a0d0824fd..761cb034ebc7296388eeb4218ce659f09161c304 100644 (file)
--- a/openssl.c
+++ b/openssl.c
@@ -2085,7 +2085,7 @@ void openconnect_close_https(struct openconnect_info *vpninfo, int final)
                SSL_free(vpninfo->https_ssl);
                vpninfo->https_ssl = NULL;
        }
-       if (vpninfo->ssl_fd != -1) {
+       if (vpninfo->ssl_fd >= 0) {
                unmonitor_fd(vpninfo, ssl);
                closesocket(vpninfo->ssl_fd);
                vpninfo->ssl_fd = -1;