]> www.infradead.org Git - users/willy/xarray.git/commitdiff
i2c: imx: add some dev_err_probe calls
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Tue, 8 Apr 2025 10:02:59 +0000 (12:02 +0200)
committerAndi Shyti <andi@smida.it>
Mon, 19 May 2025 20:23:54 +0000 (22:23 +0200)
Add corresponding error messages if DMA channels are not available during
probe. Using dev_err_probe adds deferred probe messages as well.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250408100300.556703-1-alexander.stein@ew.tq-group.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-imx.c

index 9e5d454d8318e819095b41c052aa08f35d9a2816..de01dfecb16e6692ef4d4b32273ece07f98b34ee 100644 (file)
@@ -1711,11 +1711,11 @@ static int i2c_imx_probe(struct platform_device *pdev)
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)
-               return irq;
+               return dev_err_probe(&pdev->dev, irq, "can't get IRQ\n");
 
        base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
        if (IS_ERR(base))
-               return PTR_ERR(base);
+               return dev_err_probe(&pdev->dev, PTR_ERR(base), "can't get IO memory\n");
 
        phy_addr = (dma_addr_t)res->start;
        i2c_imx = devm_kzalloc(&pdev->dev, sizeof(*i2c_imx), GFP_KERNEL);
@@ -1810,13 +1810,15 @@ static int i2c_imx_probe(struct platform_device *pdev)
         */
        ret = i2c_imx_dma_request(i2c_imx, phy_addr);
        if (ret) {
-               if (ret == -EPROBE_DEFER)
+               if (ret == -EPROBE_DEFER) {
+                       dev_err_probe(&pdev->dev, ret, "can't get DMA channels\n");
                        goto clk_notifier_unregister;
-               else if (ret == -ENODEV)
+               } else if (ret == -ENODEV) {
                        dev_dbg(&pdev->dev, "Only use PIO mode\n");
-               else
+               } else {
                        dev_warn(&pdev->dev, "Failed to setup DMA (%pe), only use PIO mode\n",
                                 ERR_PTR(ret));
+               }
        }
 
        /* Add I2C adapter */