]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/bridge: tc358767: Switch to devm MIPI-DSI helpers
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Wed, 17 May 2023 12:21:06 +0000 (14:21 +0200)
committerRobert Foss <rfoss@kernel.org>
Wed, 17 May 2023 15:13:19 +0000 (17:13 +0200)
DSI device registering and attaching needs to be undone upon
deregistration. This fixes module unload/load.

Fixes: bbfd3190b656 ("drm/bridge: tc358767: Add DSI-to-DPI mode support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230517122107.1766673-1-alexander.stein@ew.tq-group.com
drivers/gpu/drm/bridge/tc358767.c

index 91f7cb56a654d698179f4b100369a29116086ce6..d6349af4f1b62a14c00c52a3faddddb17e0a544d 100644 (file)
@@ -1890,7 +1890,7 @@ static int tc_mipi_dsi_host_attach(struct tc_data *tc)
        if (dsi_lanes < 0)
                return dsi_lanes;
 
-       dsi = mipi_dsi_device_register_full(host, &info);
+       dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
        if (IS_ERR(dsi))
                return dev_err_probe(dev, PTR_ERR(dsi),
                                     "failed to create dsi device\n");
@@ -1901,7 +1901,7 @@ static int tc_mipi_dsi_host_attach(struct tc_data *tc)
        dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
                          MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;
 
-       ret = mipi_dsi_attach(dsi);
+       ret = devm_mipi_dsi_attach(dev, dsi);
        if (ret < 0) {
                dev_err(dev, "failed to attach dsi to host: %d\n", ret);
                return ret;