]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ixgbe: Clean up redundancy in hw_enc_features
authorMark Rustad <mark.d.rustad@intel.com>
Wed, 18 Nov 2015 23:37:04 +0000 (15:37 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Wed, 6 Jul 2016 23:40:40 +0000 (16:40 -0700)
Orabug: 23177316

Clean up minor redundancy in the setting of hw_enc_features that
makes it appears that X550 uniquely has more encapsulation features
than other devices. The driver only supports one more feature, so
make it look that way. No longer set NETIF_F_SG since that is set
by the register_netdev call. Thanks to Alex Duyck for noticing this
slight confusion.

Reported-by: Alexander Duyck <aduyck@mirantis.com>
Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit fb8ad4a592c627783dc18cc147c7f4de55cf318d)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index 241db7e2a528fad68b92e0bbe17a0bedec5f5e45..fb07e223cae771cce6ff8e9bf51837237c3094b6 100644 (file)
@@ -9004,8 +9004,7 @@ skip_sriov:
        netdev->vlan_features |= NETIF_F_IPV6_CSUM;
        netdev->vlan_features |= NETIF_F_SG;
 
-       netdev->hw_enc_features |= NETIF_F_SG | NETIF_F_IP_CSUM |
-                                  NETIF_F_IPV6_CSUM;
+       netdev->hw_enc_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
 
        netdev->priv_flags |= IFF_UNICAST_FLT;
        netdev->priv_flags |= IFF_SUPP_NOFCS;
@@ -9014,9 +9013,7 @@ skip_sriov:
        switch (adapter->hw.mac.type) {
        case ixgbe_mac_X550:
        case ixgbe_mac_X550EM_x:
-               netdev->hw_enc_features |= NETIF_F_RXCSUM |
-                                          NETIF_F_IP_CSUM |
-                                          NETIF_F_IPV6_CSUM;
+               netdev->hw_enc_features |= NETIF_F_RXCSUM;
                break;
        default:
                break;