]> www.infradead.org Git - users/mchehab/rasdaemon.git/commitdiff
rasdaemon: fix memory leak in ras-events.c:add_event_handler()
authorShiju Jose <shiju.jose@huawei.com>
Wed, 16 Oct 2019 16:33:58 +0000 (17:33 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 20 Nov 2019 04:16:24 +0000 (05:16 +0100)
This patch rearranges the free(page) call to prevent the
memory leak when __toggle_ras_mc_event() fail.

Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
ras-events.c

index fc6b2886bac7be9ccdf7a9b8312457062ec729e7..f912daed03ccdd46fa1dc6a6e7baed68ff00b43d 100644 (file)
@@ -688,6 +688,7 @@ static int add_event_handler(struct ras_events *ras, struct pevent *pevent,
 
        /* Enable RAS events */
        rc = __toggle_ras_mc_event(ras, group, event, 1);
+       free(page);
        if (rc < 0) {
                log(TERM, LOG_ERR, "Can't enable %s:%s tracing\n",
                    group, event);
@@ -697,7 +698,6 @@ static int add_event_handler(struct ras_events *ras, struct pevent *pevent,
 
        log(ALL, LOG_INFO, "Enabled event %s:%s\n", group, event);
 
-       free(page);
        return 0;
 }