]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: spi-imx: Fix casting warnings
authorHardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Tue, 8 Oct 2024 05:55:46 +0000 (11:25 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 8 Oct 2024 17:17:33 +0000 (18:17 +0100)
Sparse warnings:

drivers/spi/spi-imx.c:410:19: warning: cast to restricted __be32
drivers/spi/spi-imx.c:410:19: warning: cast to restricted __be32
drivers/spi/spi-imx.c:410:19: warning: cast to restricted __be32
drivers/spi/spi-imx.c:410:19: warning: cast to restricted __be32
drivers/spi/spi-imx.c:410:19: warning: cast to restricted __be32
drivers/spi/spi-imx.c:410:19: warning: cast to restricted __be32
drivers/spi/spi-imx.c:439:21: warning: incorrect type in assignment (different base types)
drivers/spi/spi-imx.c:439:21:    expected unsigned int [addressable] [usertype] val
drivers/spi/spi-imx.c:439:21:    got restricted __be32 [usertype]

Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20241008055644.4900-3-hardevsinh.palaniya@siliconsignals.io
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-imx.c

index adfd7d74a98438ee625166321654fedc91078c18..84c3da1a1e22ea8f79b1e117e688f974d2d1112d 100644 (file)
@@ -407,7 +407,7 @@ static void spi_imx_buf_tx_swap(struct spi_imx_data *spi_imx)
 
 static void mx53_ecspi_rx_target(struct spi_imx_data *spi_imx)
 {
-       u32 val = be32_to_cpu(readl(spi_imx->base + MXC_CSPIRXDATA));
+       u32 val = ioread32be(spi_imx->base + MXC_CSPIRXDATA);
 
        if (spi_imx->rx_buf) {
                int n_bytes = spi_imx->target_burst % sizeof(val);
@@ -436,13 +436,12 @@ static void mx53_ecspi_tx_target(struct spi_imx_data *spi_imx)
        if (spi_imx->tx_buf) {
                memcpy(((u8 *)&val) + sizeof(val) - n_bytes,
                       spi_imx->tx_buf, n_bytes);
-               val = cpu_to_be32(val);
                spi_imx->tx_buf += n_bytes;
        }
 
        spi_imx->count -= n_bytes;
 
-       writel(val, spi_imx->base + MXC_CSPITXDATA);
+       iowrite32be(val, spi_imx->base + MXC_CSPITXDATA);
 }
 
 /* MX51 eCSPI */