I have here a mtd part which is 3 GiB with a flash page size of 256KiB.

The 2GiB limit is at erase block 8192. In mtd_is_bad() the computation
for the MEMGETBADBLOCK ioctl() looks like the following:

| seek = eb * mtd->eb_size;

with both eb and mtd->eb_size being a signed int results in seek being a
signed result.

The _FILE_OFFSET_BITS=64 define is required to switch off_t from 32bit
to 64bit an 32bit systems. This is required in order to keep using
lseek() as lseek64 on 32bit system. Without this change lseek() in
mtd_read() is called with a 32bit value with most significat bit set and
the kernel performs a sign extension for the 64bit value which is used
in the mtd layer.

The last change also changes the size of the parameter which is passed
to the MEMGETBADBLOCK ioctl() from 32 to 64bit. The counter part in
kernel is also defined as loff_t which is of type __kernel_loff_t and
this is "long long". So this must have been broken for a while unless I
missed something.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

diff --git a/common.mk b/common.mk
index 77d28bfa0904cb36afa410e53c51e927e22c2a90..65fc1ccf188901ab08aaff75d9039decc766a88c 100644 (file)
--- a/common.mk
+++ b/common.mk
@@ -2,7 +2,7 @@ CC := $(CROSS)gcc
 AR := $(CROSS)ar
 RANLIB := $(CROSS)ranlib
 CFLAGS ?= -O2 -g
-CFLAGS += -Wall -Wwrite-strings -W
+CFLAGS += -Wall -Wwrite-strings -W -D_FILE_OFFSET_BITS=64
 
 DESTDIR ?= /usr/local
 PREFIX=/usr

diff --git a/ubi-utils/new-utils/src/libmtd.c b/ubi-utils/new-utils/src/libmtd.c
index aab4b0ea05f58a7907052e08a7496279ea54bb63..b60ddbdfd08c031aad8cf3c632abdb4b5979e832 100644 (file)
--- a/ubi-utils/new-utils/src/libmtd.c
+++ b/ubi-utils/new-utils/src/libmtd.c
@@ -189,7 +189,7 @@ int mtd_is_bad(const struct mtd_info *mtd, int eb)
        if (!mtd->allows_bb)
                return 0;
 
-       seek = eb * mtd->eb_size;
+       seek = (loff_t)eb * mtd->eb_size;
        ret = ioctl(mtd->fd, MEMGETBADBLOCK, &seek);
        if (ret == -1) {
                sys_errmsg("MEMGETBADBLOCK ioctl failed for "
@@ -231,7 +231,7 @@ int mtd_read(const struct mtd_info *mtd, int eb, int offs, void *buf, int len)
        }
 
        /* Seek to the beginning of the eraseblock */
-       seek = eb * mtd->eb_size + offs;
+       seek = (off_t)eb * mtd->eb_size + offs;
        if (lseek(mtd->fd, seek, SEEK_SET) != seek) {
                sys_errmsg("cannot seek mtd%d to offset %llu",
                           mtd->num, (unsigned long long)seek);
@@ -296,7 +296,7 @@ int mtd_write(const struct mtd_info *mtd, int eb, int offs, void *buf, int len)
 #endif
 
        /* Seek to the beginning of the eraseblock */
-       seek = eb * mtd->eb_size + offs;
+       seek = (off_t)eb * mtd->eb_size + offs;
        if (lseek(mtd->fd, seek, SEEK_SET) != seek) {
                sys_errmsg("cannot seek mtd%d to offset %llu",
                           mtd->num, (unsigned long long)seek);