]> www.infradead.org Git - users/hch/misc.git/commitdiff
irqchip/irq-bcm2712-mip: Set EOI/ACK flags in msi_parent_ops
authorStanimir Varbanov <svarbanov@suse.de>
Mon, 7 Apr 2025 12:59:18 +0000 (15:59 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 7 Apr 2025 14:27:48 +0000 (16:27 +0200)
The recently introduced msi_parent_ops::chip_flags sets irq_eoi()/irq_ack()
conditionally, but MIP driver has not been updated. Populate chip_flags
with EOI | ACK flags.

Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
Signed-off-by: Stanimir Varbanov <svarbanov@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250407125918.3021454-1-svarbanov@suse.de
drivers/irqchip/irq-bcm2712-mip.c

index 49a19db2d1e1b32c5384eed7ffa9e79968553ebb..4cce24233f0f348015c7eb845533184b67850f1d 100644 (file)
@@ -163,6 +163,7 @@ static const struct irq_domain_ops mip_middle_domain_ops = {
 static const struct msi_parent_ops mip_msi_parent_ops = {
        .supported_flags        = MIP_MSI_FLAGS_SUPPORTED,
        .required_flags         = MIP_MSI_FLAGS_REQUIRED,
+       .chip_flags             = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
        .bus_select_token       = DOMAIN_BUS_GENERIC_MSI,
        .bus_select_mask        = MATCH_PCI_MSI,
        .prefix                 = "MIP-MSI-",