]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
pinctrl: stmfx: Use string_choices API instead of ternary operator
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 26 Aug 2024 09:53:06 +0000 (12:53 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 30 Aug 2024 22:11:29 +0000 (00:11 +0200)
Use modern string_choices API instead of manually determining the
output using ternary operator.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/20240826095306.1420628-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-stmfx.c

index 6313be370eb7d4fbc917fce3c688c98cf1aba69a..d2c5321dd025f87493440955fd69c834aabf698f 100644 (file)
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/seq_file.h>
+#include <linux/string_choices.h>
 
 #include <linux/pinctrl/pinconf.h>
 #include <linux/pinctrl/pinmux.h>
@@ -369,14 +370,14 @@ static void stmfx_pinconf_dbg_show(struct pinctrl_dev *pctldev,
                return;
 
        if (dir == GPIO_LINE_DIRECTION_OUT) {
-               seq_printf(s, "output %s ", val ? "high" : "low");
+               seq_printf(s, "output %s ", str_high_low(val));
                if (type)
                        seq_printf(s, "open drain %s internal pull-up ",
                                   pupd ? "with" : "without");
                else
                        seq_puts(s, "push pull no pull ");
        } else {
-               seq_printf(s, "input %s ", val ? "high" : "low");
+               seq_printf(s, "input %s ", str_high_low(val));
                if (type)
                        seq_printf(s, "with internal pull-%s ",
                                   pupd ? "up" : "down");