btrfs: warn if EXTENT_BUFFER_UPTODATE is set while reading

We recently tracked down a race condition that triggered a read for an
extent buffer with EXTENT_BUFFER_UPTODATE already set.  While this read
was in progress, other concurrent readers would see the UPTODATE bit and
return early as if the read was already complete, making accesses to the
extent buffer conflict with the read operation that was overwriting it.

Add a WARN_ON() to end_bbio_meta_read() for this situation to make
similar races easier to spot in the future.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Tavian Barnes <tavianator@tavianator.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 23bdd05b5cec951c7e57b0caa6c044ee5fdaef0d..ecb18a8db373277a4705584c7eaadd613731ad2d 100644 (file)
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -4275,6 +4275,13 @@ static void end_bbio_meta_read(struct btrfs_bio *bbio)
        struct folio_iter fi;
        u32 bio_offset = 0;
 
+       /*
+        * If the extent buffer is marked UPTODATE before the read operation
+        * completes, other calls to read_extent_buffer_pages() will return
+        * early without waiting for the read to finish, causing data races.
+        */
+       WARN_ON(test_bit(EXTENT_BUFFER_UPTODATE, &eb->bflags));
+
        eb->read_mirror = bbio->mirror_num;
 
        if (uptodate &&