]> www.infradead.org Git - nvme.git/commitdiff
nvmet: do not return 'reserved' for empty TSAS values
authorHannes Reinecke <hare@kernel.org>
Mon, 17 Jun 2024 07:27:26 +0000 (09:27 +0200)
committerKeith Busch <kbusch@kernel.org>
Mon, 17 Jun 2024 18:29:22 +0000 (11:29 -0700)
The 'TSAS' value is only defined for TCP and RDMA, but returning
'reserved' for undefined values tricked nvmetcli to try to write
'reserved' when restoring from a config file. This caused an error
and the configuration would not be applied.

Fixes: 3f123494db72 ("nvmet: make TCP sectype settable via configfs")
Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/configfs.c

index bd87dfd173a4cbbd91ead9f689962b3106b90b55..e60224356048a4f93f3af5ea658eb0fc763d12bb 100644 (file)
@@ -410,7 +410,7 @@ static ssize_t nvmet_addr_tsas_show(struct config_item *item,
                                return sprintf(page, "%s\n", nvmet_addr_tsas_rdma[i].name);
                }
        }
-       return sprintf(page, "reserved\n");
+       return sprintf(page, "\n");
 }
 
 static ssize_t nvmet_addr_tsas_store(struct config_item *item,