phy: exynos5-usbdrd: make phy_isol() take a bool for clarity

on / not on is just a boolean flag and is a bit misleading as currently
on==1 means to turn off the power, and on==0 to turn power on.

Rename the flag and make it a bool to avoid confusion of future readers
of this code. No functional change.

While at it, fix a whitespace issue in nearby comment.

No functional change.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240507-samsung-usb-phy-fixes-v1-3-4ccba5afa7cc@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index 1b209ab7a26802ae1ed45b16a51698b52d4014d7..ed4898741c99afae420be7a7babfaf19011fb687 100644 (file)
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -173,7 +173,7 @@ struct exynos5_usbdrd_phy;
 
 struct exynos5_usbdrd_phy_config {
        u32 id;
-       void (*phy_isol)(struct phy_usb_instance *inst, u32 on);
+       void (*phy_isol)(struct phy_usb_instance *inst, bool isolate);
        void (*phy_init)(struct exynos5_usbdrd_phy *phy_drd);
        unsigned int (*set_refclk)(struct phy_usb_instance *inst);
 };
@@ -273,14 +273,14 @@ static unsigned int exynos5_rate_to_clk(unsigned long rate, u32 *reg)
 }
 
 static void exynos5_usbdrd_phy_isol(struct phy_usb_instance *inst,
-                                               unsigned int on)
+                                   bool isolate)
 {
        unsigned int val;
 
        if (!inst->reg_pmu)
                return;
 
-       val = on ? 0 : EXYNOS4_PHY_ENABLE;
+       val = isolate ? 0 : EXYNOS4_PHY_ENABLE;
 
        regmap_update_bits(inst->reg_pmu, inst->pmu_offset,
                           EXYNOS4_PHY_ENABLE, val);
@@ -525,8 +525,8 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy)
                }
        }
 
-       /* Power-on PHY*/
-       inst->phy_cfg->phy_isol(inst, 0);
+       /* Power-on PHY */
+       inst->phy_cfg->phy_isol(inst, false);
 
        return 0;
 
@@ -553,7 +553,7 @@ static int exynos5_usbdrd_phy_power_off(struct phy *phy)
        dev_dbg(phy_drd->dev, "Request to power_off usbdrd_phy phy\n");
 
        /* Power-off the PHY */
-       inst->phy_cfg->phy_isol(inst, 1);
+       inst->phy_cfg->phy_isol(inst, true);
 
        /* Disable VBUS supply */
        if (phy_drd->vbus)