net: ngbe: Fix phy mode set to external phy

The MAC only has add the TX delay and it can not be modified.
MAC and PHY are both set the TX delay cause transmission problems.
So just disable TX delay in PHY, when use rgmii to attach to
external phy, set PHY_INTERFACE_MODE_RGMII_RXID to phy drivers.
And it is does not matter to internal phy.

Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink")
Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: stable@vger.kernel.org # 6.3+
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/E6759CF1387CF84C+20240820030425.93003-1-mengyuanlou@net-swift.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c
index ec54b18c5fe73b942cdeb4c362168c06e7b16a28..a5e9b779c44d0100e16a3e380964cafeeaabc4a7 100644 (file)
--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c
+++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c
@@ -124,8 +124,12 @@ static int ngbe_phylink_init(struct wx *wx)
                                   MAC_SYM_PAUSE | MAC_ASYM_PAUSE;
        config->mac_managed_pm = true;
 
-       phy_mode = PHY_INTERFACE_MODE_RGMII_ID;
-       __set_bit(PHY_INTERFACE_MODE_RGMII_ID, config->supported_interfaces);
+       /* The MAC only has add the Tx delay and it can not be modified.
+        * So just disable TX delay in PHY, and it is does not matter to
+        * internal phy.
+        */
+       phy_mode = PHY_INTERFACE_MODE_RGMII_RXID;
+       __set_bit(PHY_INTERFACE_MODE_RGMII_RXID, config->supported_interfaces);
 
        phylink = phylink_create(config, NULL, phy_mode, &ngbe_mac_ops);
        if (IS_ERR(phylink))