]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
eeprom: at24: Drop of_match_ptr() and ACPI_PTR() protections
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 25 Feb 2025 10:08:38 +0000 (12:08 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 3 Mar 2025 11:08:24 +0000 (12:08 +0100)
These result in a very small reduction in driver size, but at the cost
of more complex build and slightly harder to read code. In the case of
of_match_ptr() it also prevents use of PRP0001 ACPI based identification.
In this particular case we have a valid ACPI/PNP ID that should be used
in preference to PRP0001 but doesn't mean we should prevent that route.

With this done, drop unneeded of*.h inclusions and __maybe_unused markers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250225100838.362125-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/misc/eeprom/at24.c

index 0a7c7f29406c79a4215c5a52c0f787c8dc33641b..f721825199ce92a503c4e75ad2159810ab1a16de 100644 (file)
@@ -18,8 +18,6 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/nvmem-provider.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/property.h>
 #include <linux/regmap.h>
@@ -252,7 +250,7 @@ static const struct i2c_device_id at24_ids[] = {
 };
 MODULE_DEVICE_TABLE(i2c, at24_ids);
 
-static const struct of_device_id __maybe_unused at24_of_match[] = {
+static const struct of_device_id at24_of_match[] = {
        { .compatible = "atmel,24c00",          .data = &at24_data_24c00 },
        { .compatible = "atmel,24c01",          .data = &at24_data_24c01 },
        { .compatible = "atmel,24cs01",         .data = &at24_data_24cs01 },
@@ -286,7 +284,7 @@ static const struct of_device_id __maybe_unused at24_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, at24_of_match);
 
-static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = {
+static const struct acpi_device_id at24_acpi_ids[] = {
        { "INT3499",    (kernel_ulong_t)&at24_data_INT3499 },
        { "TPF0001",    (kernel_ulong_t)&at24_data_24c1024 },
        { /* END OF LIST */ }
@@ -848,8 +846,8 @@ static struct i2c_driver at24_driver = {
        .driver = {
                .name = "at24",
                .pm = &at24_pm_ops,
-               .of_match_table = of_match_ptr(at24_of_match),
-               .acpi_match_table = ACPI_PTR(at24_acpi_ids),
+               .of_match_table = at24_of_match,
+               .acpi_match_table = at24_acpi_ids,
        },
        .probe = at24_probe,
        .remove = at24_remove,