]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amd/pm: Prevent division by zero
authorDenis Arefev <arefev@swemel.ru>
Fri, 21 Mar 2025 10:52:31 +0000 (13:52 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 26 Mar 2025 21:41:03 +0000 (17:41 -0400)
The user can set any speed value.
If speed is greater than UINT_MAX/8, division by zero is possible.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: c05d1c401572 ("drm/amd/swsmu: add aldebaran smu13 ip support (v3)")
Signed-off-by: Denis Arefev <arefev@swemel.ru>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c

index 0915d6377613b6d74922a5dba7440d515eca7cd7..ba5a9012dbd5e3e56272c8a00bd1cc77500ec9d0 100644 (file)
@@ -1226,7 +1226,7 @@ int smu_v13_0_set_fan_speed_rpm(struct smu_context *smu,
        uint32_t tach_period;
        int ret;
 
-       if (!speed)
+       if (!speed || speed > UINT_MAX/8)
                return -EINVAL;
 
        ret = smu_v13_0_auto_fan_control(smu, 0);