]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net/mlx4_core: need to call close fw if alloc icm is called twice
authorCarol Soto <clsoto@linux.vnet.ibm.com>
Tue, 2 Jun 2015 21:07:24 +0000 (16:07 -0500)
committerSantosh Shilimkar <santosh.shilimkar@oracle.com>
Wed, 12 Aug 2015 18:50:50 +0000 (11:50 -0700)
If mlx4_enable_sriov is called by adapter without this
feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc
icm is called twice without freeing the structures from the first time.

Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Carol L Soto <clsoto@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit ed3d2276ef72be23c6367358d80004130d8c797d)

Orabug: 21606315

Acked-by: Mukesh Kacker <mukesh.kacker@oracle.com>
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
drivers/net/ethernet/mellanox/mlx4/main.c

index 2bc9efb4f558033a9ea1a91f349c73bb910f558a..b0a8f8b5f7683be40ab958bc00e95a8593697655 100644 (file)
@@ -3058,6 +3058,7 @@ slave_start:
                                                                  existing_vfs,
                                                                  reset_flow);
 
+                               mlx4_close_fw(dev);
                                mlx4_cmd_cleanup(dev, MLX4_CMD_CLEANUP_ALL);
                                dev->flags = dev_flags;
                                if (!SRIOV_VALID_STATE(dev->flags)) {