]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
io_uring: simplify io_uring_cmd return
authorPavel Begunkov <asml.silence@gmail.com>
Wed, 24 Jul 2024 11:16:19 +0000 (12:16 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 24 Jul 2024 14:01:49 +0000 (08:01 -0600)
We don't have to return error code from an op handler back to core
io_uring, so once io_uring_cmd() sets the results and handles errors we
can juts return IOU_OK and simplify the code.

Note, only valid with e0b23d9953b0c ("io_uring: optimise ltimeout for
inline execution"), there was a problem with iopoll before.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/8eae2be5b2a49236cd5f1dadbd1aa5730e9e2d4f.1721819383.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/uring_cmd.c

index a54163a8396861c1d41c1e78bda82a32d51bb840..8391c7c7c1ec48182487e54642c5dadd0f2b40a7 100644 (file)
@@ -265,7 +265,7 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags)
                req_set_fail(req);
        io_req_uring_cleanup(req, issue_flags);
        io_req_set_res(req, ret, 0);
-       return ret < 0 ? ret : IOU_OK;
+       return IOU_OK;
 }
 
 int io_uring_cmd_import_fixed(u64 ubuf, unsigned long len, int rw,