]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Condition `!dtlsver` is true after `else if (dtlsver)`
authorDimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
Thu, 9 Dec 2021 10:09:09 +0000 (11:09 +0100)
committerDimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
Sat, 26 Feb 2022 15:51:08 +0000 (16:51 +0100)
Fixes a Codacy alert:
Condition '!dtlsver' is always false

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>
openssl-dtls.c

index f9b728c17dbb29132448d18ac42553df9bd41488..7685346f0d7b77eaf54a0cf247f482c471142c18 100644 (file)
@@ -511,7 +511,7 @@ int start_dtls_handshake(struct openconnect_info *vpninfo, int dtls_fd)
                for (i = 0; i < sk_SSL_CIPHER_num(ciphers); i++) {
                        ssl_ciph = sk_SSL_CIPHER_value(ciphers, i);
                        /* For PSK-NEGOTIATE just use the first one we find */
-                       if (!dtlsver || !strcmp(SSL_CIPHER_get_name(ssl_ciph), cipher))
+                       if (!strcmp(SSL_CIPHER_get_name(ssl_ciph), cipher))
                                break;
                }