usb: acpi: add device link between tunneled USB3 device and USB4 Host Interface

Describe the power management relationship between a tunneled USB3 device
and the tunnel providing USB4 host with a device link as the relationship
between them is not evident from normal device hierarchy.

Tunneling capable ports have an ACPI _DSD object pointing to the USB4
Host Interface that is used to establish USB3 3.x tunnels

Set the link directly between tunneled USB3 devices and USB4 Host
Interface to ensure that the USB4 host can runtime suspend if no tunneled
USB 3.x devices exist.
Current Thunderbolt code sets a link between USB4 Host Interface and USB3
xHCI host which prevents USB4 Host Interface from runtime suspending even
if the USB3 host is only serving native USB devices.

See commit b2be2b05cf3b ("thunderbolt: Create device links from ACPI
description") for details.

As the device link is only set for USB3 devices that are already tunneled
we know that USB4 Host Interface exists and is bound to its driver.

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20240830152630.3943215-4-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c
index 7f8a912d4fe2a26e8b3a4902254af659982a2fb5..21585ed89ef849d2f2a1ce6c4196dcfc64ac9176 100644 (file)
--- a/drivers/usb/core/usb-acpi.c
+++ b/drivers/usb/core/usb-acpi.c
@@ -142,6 +142,53 @@ int usb_acpi_set_power_state(struct usb_device *hdev, int index, bool enable)
 }
 EXPORT_SYMBOL_GPL(usb_acpi_set_power_state);
 
+/**
+ * usb_acpi_add_usb4_devlink - add device link to USB4 Host Interface for tunneled USB3 devices
+ *
+ * @udev: Tunneled USB3 device connected to a roothub.
+ *
+ * Adds a device link between a tunneled USB3 device and the USB4 Host Interface
+ * device to ensure correct runtime PM suspend and resume order. This function
+ * should only be called for tunneled USB3 devices.
+ * The USB4 Host Interface this tunneled device depends on is found from the roothub
+ * port ACPI device specific data _DSD entry.
+ *
+ * Return: negative error code on failure, 0 otherwise
+ */
+static int usb_acpi_add_usb4_devlink(struct usb_device *udev)
+{
+       const struct device_link *link;
+       struct usb_port *port_dev;
+       struct usb_hub *hub;
+
+       if (!udev->parent || udev->parent->parent)
+               return 0;
+
+       hub = usb_hub_to_struct_hub(udev->parent);
+       port_dev = hub->ports[udev->portnum - 1];
+
+       struct fwnode_handle *nhi_fwnode __free(fwnode_handle) =
+               fwnode_find_reference(dev_fwnode(&port_dev->dev), "usb4-host-interface", 0);
+
+       if (IS_ERR(nhi_fwnode))
+               return 0;
+
+       link = device_link_add(&port_dev->child->dev, nhi_fwnode->dev,
+                              DL_FLAG_AUTOREMOVE_CONSUMER |
+                              DL_FLAG_RPM_ACTIVE |
+                              DL_FLAG_PM_RUNTIME);
+       if (!link) {
+               dev_err(&port_dev->dev, "Failed to created device link from %s to %s\n",
+                       dev_name(&port_dev->child->dev), dev_name(nhi_fwnode->dev));
+               return -EINVAL;
+       }
+
+       dev_dbg(&port_dev->dev, "Created device link from %s to %s\n",
+               dev_name(&port_dev->child->dev), dev_name(nhi_fwnode->dev));
+
+       return 0;
+}
+
 /*
  * Private to usb-acpi, all the core needs to know is that
  * port_dev->location is non-zero when it has been set by the firmware.
@@ -262,6 +309,12 @@ usb_acpi_find_companion_for_device(struct usb_device *udev)
        if (!hub)
                return NULL;
 
+
+       /* Tunneled USB3 devices depend on USB4 Host Interface, set device link to it */
+       if (udev->speed >= USB_SPEED_SUPER &&
+           udev->tunnel_mode != USB_LINK_NATIVE)
+               usb_acpi_add_usb4_devlink(udev);
+
        /*
         * This is an embedded USB device connected to a port and such
         * devices share port's ACPI companion.