]> www.infradead.org Git - users/hch/configfs.git/commitdiff
net/mlx5e: CT: Initialize err to 0 to avoid warning
authorCosmin Ratiu <cratiu@nvidia.com>
Mon, 8 Jul 2024 08:00:25 +0000 (11:00 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Jul 2024 01:59:35 +0000 (18:59 -0700)
It is theoretically possible to return bogus uninitialized values from
mlx5_tc_ct_entry_replace_rules, even though in practice this will never
be the case as the flow rule will be part of at least the regular ct
table or the ct nat table, if not both.

But to reduce noise, initialize err to 0.

Fixes: 49d37d05f216 ("net/mlx5: CT: Separate CT and CT-NAT tuple entries")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20240708080025.1593555-11-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c

index b49d87a51f21713876ff0a1d59253c152d94e66b..8cf8ba2622f2bfaa03b41cc9af0357bf8050e71e 100644 (file)
@@ -1145,7 +1145,7 @@ mlx5_tc_ct_entry_replace_rules(struct mlx5_tc_ct_priv *ct_priv,
                               struct mlx5_ct_entry *entry,
                               u8 zone_restore_id)
 {
-       int err;
+       int err = 0;
 
        if (mlx5_tc_ct_entry_in_ct_table(entry)) {
                err = mlx5_tc_ct_entry_replace_rule(ct_priv, flow_rule, entry, false,