Bluetooth: L2CAP: Fix calling sk_filter on non-socket based channel

Only sockets will have the chan->data set to an actual sk, channels
like A2MP would have its own data which would likely cause a crash when
calling sk_filter, in order to fix this a new callback has been
introduced so channels can implement their own filtering if necessary.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
index 8f1e6a7a2df84aa9231177c3af74da408710feaf..1d1232917de72080167747e45d8d8834e9a59b91 100644 (file)
--- a/include/net/bluetooth/l2cap.h
+++ b/include/net/bluetooth/l2cap.h
@@ -665,6 +665,8 @@ struct l2cap_ops {
        struct sk_buff          *(*alloc_skb) (struct l2cap_chan *chan,
                                               unsigned long hdr_len,
                                               unsigned long len, int nb);
+       int                     (*filter) (struct l2cap_chan * chan,
+                                          struct sk_buff *skb);
 };
 
 struct l2cap_conn {

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index ade83e2245670e152ab49df24770536f073f944b..1ab27b90ddcbcba17594159f2f1b9908c525910b 100644 (file)
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -7301,9 +7301,10 @@ static int l2cap_data_rcv(struct l2cap_chan *chan, struct sk_buff *skb)
                goto drop;
        }
 
-       if ((chan->mode == L2CAP_MODE_ERTM ||
-            chan->mode == L2CAP_MODE_STREAMING) && sk_filter(chan->data, skb))
-               goto drop;
+       if (chan->ops->filter) {
+               if (chan->ops->filter(chan, skb))
+                       goto drop;
+       }
 
        if (!control->sframe) {
                int err;

diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index e7cfe28140c39b0eba42b0091b9f640b65737960..f1b1edd0b6974319dedd22cdc9948bfd99109b2d 100644 (file)
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -1664,6 +1664,19 @@ static void l2cap_sock_suspend_cb(struct l2cap_chan *chan)
        sk->sk_state_change(sk);
 }
 
+static int l2cap_sock_filter(struct l2cap_chan *chan, struct sk_buff *skb)
+{
+       struct sock *sk = chan->data;
+
+       switch (chan->mode) {
+       case L2CAP_MODE_ERTM:
+       case L2CAP_MODE_STREAMING:
+               return sk_filter(sk, skb);
+       }
+
+       return 0;
+}
+
 static const struct l2cap_ops l2cap_chan_ops = {
        .name                   = "L2CAP Socket Interface",
        .new_connection         = l2cap_sock_new_connection_cb,
@@ -1679,6 +1692,7 @@ static const struct l2cap_ops l2cap_chan_ops = {
        .get_sndtimeo           = l2cap_sock_get_sndtimeo_cb,
        .get_peer_pid           = l2cap_sock_get_peer_pid_cb,
        .alloc_skb              = l2cap_sock_alloc_skb_cb,
+       .filter                 = l2cap_sock_filter,
 };
 
 static void l2cap_sock_destruct(struct sock *sk)