crypto: qat - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor McLoughlin <conor.mcloughlin@intel.com>
Cc: Waiman Long <longman@redhat.com>
Cc: qat-linux@intel.com
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/qat/qat_c3xxx/adf_drv.c b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
index 763c2166ee0ec970a03366c0897b11c9eea2e5a3..d937cc7248a5e3f578580eab5a8aa0fc11873c1f 100644 (file)
--- a/drivers/crypto/qat/qat_c3xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
index 613c7d5644ced6d250adefdf3d49a7c4d0876938..1dc5ac859f7b4e92243693ac752f1b7f84af56ac 100644 (file)
--- a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_c62x/adf_drv.c b/drivers/crypto/qat/qat_c62x/adf_drv.c
index 9cb832963357ddcf23686cc3bfec34960646d611..2bc06c89d2fe7c6eb6df702a193a49c285dc1b85 100644 (file)
--- a/drivers/crypto/qat/qat_c62x/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62x/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_c62xvf/adf_drv.c b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
index 278452b8ef81c8a5e5aa296a38bb8caf6402fdd3..a68358b31292dce410323f9b839a9bc71b761880 100644 (file)
--- a/drivers/crypto/qat/qat_c62xvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_common/adf_cfg.c b/drivers/crypto/qat/qat_common/adf_cfg.c
index d0879790561fa68efdebcc3a643d946cacd8257d..5c7fdb0fc53d941b5de5099772601d30efb10c52 100644 (file)
--- a/drivers/crypto/qat/qat_common/adf_cfg.c
+++ b/drivers/crypto/qat/qat_common/adf_cfg.c
@@ -141,13 +141,6 @@ int adf_cfg_dev_add(struct adf_accel_dev *accel_dev)
                                                  accel_dev->debugfs_dir,
                                                  dev_cfg_data,
                                                  &qat_dev_cfg_fops);
-       if (!dev_cfg_data->debug) {
-               dev_err(&GET_DEV(accel_dev),
-                       "Failed to create qat cfg debugfs entry.\n");
-               kfree(dev_cfg_data);
-               accel_dev->cfg = NULL;
-               return -EFAULT;
-       }
        return 0;
 }
 EXPORT_SYMBOL_GPL(adf_cfg_dev_add);

diff --git a/drivers/crypto/qat/qat_common/adf_transport.c b/drivers/crypto/qat/qat_common/adf_transport.c
index 57d2622728a57c638c080d5b1c613450081978bb..ac658ce46836cb5dbea48839dd538897f0aa91f4 100644 (file)
--- a/drivers/crypto/qat/qat_common/adf_transport.c
+++ b/drivers/crypto/qat/qat_common/adf_transport.c
@@ -486,12 +486,6 @@ int adf_init_etr_data(struct adf_accel_dev *accel_dev)
        /* accel_dev->debugfs_dir should always be non-NULL here */
        etr_data->debug = debugfs_create_dir("transport",
                                             accel_dev->debugfs_dir);
-       if (!etr_data->debug) {
-               dev_err(&GET_DEV(accel_dev),
-                       "Unable to create transport debugfs entry\n");
-               ret = -ENOENT;
-               goto err_bank_debug;
-       }
 
        for (i = 0; i < num_banks; i++) {
                ret = adf_init_bank(accel_dev, &etr_data->banks[i], i,

diff --git a/drivers/crypto/qat/qat_common/adf_transport_debug.c b/drivers/crypto/qat/qat_common/adf_transport_debug.c
index 52340b9bb3873bbf1a327c7b41bbe3f2ffa5b222..e794e9d97b2cbbee2df6c8120da17bdc7eeef68f 100644 (file)
--- a/drivers/crypto/qat/qat_common/adf_transport_debug.c
+++ b/drivers/crypto/qat/qat_common/adf_transport_debug.c
@@ -163,11 +163,6 @@ int adf_ring_debugfs_add(struct adf_etr_ring_data *ring, const char *name)
        ring_debug->debug = debugfs_create_file(entry_name, S_IRUSR,
                                                ring->bank->bank_debug_dir,
                                                ring, &adf_ring_debug_fops);
-       if (!ring_debug->debug) {
-               pr_err("QAT: Failed to create ring debug entry.\n");
-               kfree(ring_debug);
-               return -EFAULT;
-       }
        ring->ring_debug = ring_debug;
        return 0;
 }
@@ -271,19 +266,9 @@ int adf_bank_debugfs_add(struct adf_etr_bank_data *bank)
 
        snprintf(name, sizeof(name), "bank_%02d", bank->bank_number);
        bank->bank_debug_dir = debugfs_create_dir(name, parent);
-       if (!bank->bank_debug_dir) {
-               pr_err("QAT: Failed to create bank debug dir.\n");
-               return -EFAULT;
-       }
-
        bank->bank_debug_cfg = debugfs_create_file("config", S_IRUSR,
                                                   bank->bank_debug_dir, bank,
                                                   &adf_bank_debug_fops);
-       if (!bank->bank_debug_cfg) {
-               pr_err("QAT: Failed to create bank debug entry.\n");
-               debugfs_remove(bank->bank_debug_dir);
-               return -EFAULT;
-       }
        return 0;
 }
 

diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index 3a9708ef4ce2147b0aa6d60aba27a56506779e3f..b11bf8c0e683951201e30e393a660ad07d1e8e76 100644 (file)
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
index 3da0f951cb590a555fea8a9d848c657888a305d9..1b762eefc6c1a122c65f6be8b6daedadd78f9d78 100644 (file)
--- a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);