]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
scsi: megaraid_sas: zero out IOC INIT and stream detection memory
authorShivasharan S <shivasharan.srikanteshwara@broadcom.com>
Fri, 5 Jan 2018 13:27:36 +0000 (05:27 -0800)
committerJack Vogel <jack.vogel@oracle.com>
Thu, 8 Mar 2018 02:44:09 +0000 (18:44 -0800)
Memory allocated for IOC_INIT command and stream detection array are not
zero'd before using. Use kzalloc instead of kmalloc to zero out the
memory allocated.

Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Orabug: 27625001
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/megaraid/megaraid_sas_fusion.c

index af3b55e9556cae1658e8651690d546ceb933a1cd..b6ced51d5c7bd73ebc442cf679c23c19cba9a55a 100644 (file)
@@ -5395,7 +5395,7 @@ static int megasas_init_fw(struct megasas_instance *instance)
                }
                for (i = 0; i < MAX_LOGICAL_DRIVES_EXT; ++i) {
                        fusion->stream_detect_by_ld[i] =
-                               kmalloc(sizeof(struct LD_STREAM_DETECT),
+                               kzalloc(sizeof(struct LD_STREAM_DETECT),
                                GFP_KERNEL);
                        if (!fusion->stream_detect_by_ld[i]) {
                                dev_err(&instance->pdev->dev,
index 2b3359ffc752b82d4b2138b15d53e865f4ebef8a..27ca2d499e940c446ca21a10ac42e2189287d6d8 100644 (file)
@@ -1607,7 +1607,7 @@ static int megasas_alloc_ioc_init_frame(struct megasas_instance *instance)
 
        fusion = instance->ctrl_context;
 
-       cmd = kmalloc(sizeof(struct megasas_cmd), GFP_KERNEL);
+       cmd = kzalloc(sizeof(struct megasas_cmd), GFP_KERNEL);
 
        if (!cmd) {
                dev_err(&instance->pdev->dev, "Failed from func: %s line: %d\n",