]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
dmaengine: ptdma: Remove unused pointer dma_cmd_cache
authorEder Zulian <ezulian@redhat.com>
Tue, 15 Apr 2025 12:13:12 +0000 (14:13 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 17 Apr 2025 07:25:55 +0000 (12:55 +0530)
The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
resource")' but it was never used.

Signed-off-by: Eder Zulian <ezulian@redhat.com>
Reviewed-by: Nathan Lynch <nathan.lynch@amd.com>
Link: https://lore.kernel.org/r/20250415121312.870124-1-ezulian@redhat.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/amd/ptdma/ptdma-dmaengine.c
drivers/dma/amd/ptdma/ptdma.h

index 715ac3ae067b857830db85e170787e30f3ae6b1d..686f8bf617635dcb8e31682802cc04840c20dbbd 100644 (file)
@@ -590,18 +590,14 @@ int pt_dmaengine_register(struct pt_device *pt)
        desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
                                         "%s-dmaengine-desc-cache",
                                         dev_name(pt->dev));
-       if (!desc_cache_name) {
-               ret = -ENOMEM;
-               goto err_cache;
-       }
+       if (!desc_cache_name)
+               return -ENOMEM;
 
        pt->dma_desc_cache = kmem_cache_create(desc_cache_name,
                                               sizeof(struct pt_dma_desc), 0,
                                               SLAB_HWCACHE_ALIGN, NULL);
-       if (!pt->dma_desc_cache) {
-               ret = -ENOMEM;
-               goto err_cache;
-       }
+       if (!pt->dma_desc_cache)
+               return -ENOMEM;
 
        dma_dev->dev = pt->dev;
        dma_dev->src_addr_widths = DMA_SLAVE_BUSWIDTH_64_BYTES;
@@ -655,9 +651,6 @@ int pt_dmaengine_register(struct pt_device *pt)
 err_reg:
        kmem_cache_destroy(pt->dma_desc_cache);
 
-err_cache:
-       kmem_cache_destroy(pt->dma_cmd_cache);
-
        return ret;
 }
 EXPORT_SYMBOL_GPL(pt_dmaengine_register);
@@ -669,5 +662,4 @@ void pt_dmaengine_unregister(struct pt_device *pt)
        dma_async_device_unregister(dma_dev);
 
        kmem_cache_destroy(pt->dma_desc_cache);
-       kmem_cache_destroy(pt->dma_cmd_cache);
 }
index 0a7939105e512239c78499e672b7007b6b6491b9..ef3f5563210773e5293243721b83039d68c46454 100644 (file)
@@ -254,7 +254,6 @@ struct pt_device {
        /* Support for the DMA Engine capabilities */
        struct dma_device dma_dev;
        struct pt_dma_chan *pt_dma_chan;
-       struct kmem_cache *dma_cmd_cache;
        struct kmem_cache *dma_desc_cache;
 
        wait_queue_head_t lsb_queue;