]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
hv_balloon: rate-limit "Unhandled message" warning
authorAnssi Hannula <anssi.hannula@bitwise.fi>
Tue, 22 Feb 2022 14:14:00 +0000 (16:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:40:19 +0000 (14:40 +0200)
[ Upstream commit 1d7286729aa616772be334eb908e11f527e1e291 ]

For a couple of times I have encountered a situation where

  hv_balloon: Unhandled message: type: 12447

is being flooded over 1 million times per second with various values,
filling the log and consuming cycles, making debugging difficult.

Add rate limiting to the message.

Most other Hyper-V drivers already have similar rate limiting in their
message callbacks.

The cause of the floods in my case was probably fixed by 96d9d1fa5cd5
("Drivers: hv: balloon: account for vmbus packet header in
max_pkt_size").

Fixes: 9aa8b50b2b3d ("Drivers: hv: Add Hyper-V balloon driver")
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20220222141400.98160-1-anssi.hannula@bitwise.fi
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hv/hv_balloon.c

index eb56e09ae15f3999478b0e75f601836c92ad175a..6a716996a6250b30ac458a8a95714b44c9f04d8e 100644 (file)
@@ -1558,7 +1558,7 @@ static void balloon_onchannelcallback(void *context)
                        break;
 
                default:
-                       pr_warn("Unhandled message: type: %d\n", dm_hdr->type);
+                       pr_warn_ratelimited("Unhandled message: type: %d\n", dm_hdr->type);
 
                }
        }