]> www.infradead.org Git - nvme.git/commitdiff
smb: propagate error code of extract_sharename()
authorKatya Orlova <e.orlova@ispras.ru>
Tue, 15 Aug 2023 13:38:31 +0000 (16:38 +0300)
committerSteve French <stfrench@microsoft.com>
Thu, 31 Aug 2023 04:38:49 +0000 (23:38 -0500)
In addition to the EINVAL, there may be an ENOMEM.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 70431bfd825d ("cifs: Support fscache indexing rewrite")
Signed-off-by: Katya Orlova <e.orlova@ispras.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/fscache.c

index 3677525ee99311b4005224931ce4a07eef4fa2a1..e5cad149f5a2d7d3f12d53ef61f78332a828c367 100644 (file)
@@ -48,7 +48,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon)
        sharename = extract_sharename(tcon->tree_name);
        if (IS_ERR(sharename)) {
                cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__);
-               return -EINVAL;
+               return PTR_ERR(sharename);
        }
 
        slen = strlen(sharename);