]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: atmel-quadspi: Add missing check for clk_prepare
authorChen Ni <nichen@iscas.ac.cn>
Wed, 15 May 2024 08:40:28 +0000 (16:40 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 27 May 2024 00:33:39 +0000 (01:33 +0100)
Add check for the return value of clk_prepare() and return the error if
it fails in order to catch the error.

Fixes: 4a2f83b7f780 ("spi: atmel-quadspi: add runtime pm support")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://msgid.link/r/20240515084028.3210406-1-nichen@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/atmel-quadspi.c

index 370c4d1572ed02fa3e3cc54b2fa768e4a9bfa21e..5aaff3bee1b78ffae7625c7f8d6ef17167a9b2b2 100644 (file)
@@ -756,8 +756,15 @@ static int __maybe_unused atmel_qspi_resume(struct device *dev)
        struct atmel_qspi *aq = spi_controller_get_devdata(ctrl);
        int ret;
 
-       clk_prepare(aq->pclk);
-       clk_prepare(aq->qspick);
+       ret = clk_prepare(aq->pclk);
+       if (ret)
+               return ret;
+
+       ret = clk_prepare(aq->qspick);
+       if (ret) {
+               clk_unprepare(aq->pclk);
+               return ret;
+       }
 
        ret = pm_runtime_force_resume(dev);
        if (ret < 0)