]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
x86/platform/olpc: Remove unused variable 'len' in olpc_dt_compatible_match()
authorZeng Heng <zengheng4@huawei.com>
Fri, 25 Oct 2024 07:42:03 +0000 (15:42 +0800)
committerIngo Molnar <mingo@kernel.org>
Thu, 6 Mar 2025 10:14:26 +0000 (11:14 +0100)
The following build warning highlights some unused code:

  arch/x86/platform/olpc/olpc_dt.c: In function ‘olpc_dt_compatible_match’:
  arch/x86/platform/olpc/olpc_dt.c:222:12: warning: variable ‘len’ set but not used [-Wunused-but-set-variable]

The compiler is right, the local variable 'len' is set but never used,
so remove it.

Fixes: a7a9bacb9a32 ("x86/platform/olpc: Use a correct version when making up a battery node")
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20241025074203.1921344-1-zengheng4@huawei.com
arch/x86/platform/olpc/olpc_dt.c

index cf5dca2dbb91db0423230d5f84a65f0d26b479cf..e108ce7dad6a1b031e3f4e26eaa17d6a6aa5a314 100644 (file)
@@ -215,13 +215,12 @@ static u32 __init olpc_dt_get_board_revision(void)
 static int __init olpc_dt_compatible_match(phandle node, const char *compat)
 {
        char buf[64], *p;
-       int plen, len;
+       int plen;
 
        plen = olpc_dt_getproperty(node, "compatible", buf, sizeof(buf));
        if (plen <= 0)
                return 0;
 
-       len = strlen(compat);
        for (p = buf; p < buf + plen; p += strlen(p) + 1) {
                if (strcmp(p, compat) == 0)
                        return 1;