]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
regulator: pm8008: fix probe failure due to negative voltage selector
authorKamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Fri, 22 Aug 2025 20:26:39 +0000 (01:56 +0530)
committerMark Brown <broonie@kernel.org>
Sun, 24 Aug 2025 21:41:04 +0000 (22:41 +0100)
In the current design, the `pm8008_regulator_get_voltage_sel()` callback
can return a negative value if the raw voltage value is read as 0 uV from
the PMIC HW register. This can cause the probe to fail when the
`machine_constraints_voltage()` check is called during the regulator
registration flow.

Fix this by using the helper `regulator_map_voltage_linear_range()` to
convert the raw value to a voltage selector inside the mentioned get
voltage selector function. This ensures that the value returned is always
within the defined range.

Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Message-ID: <20250823-pm8008-negitive-selector-v1-1-52b026a4b5e8@quicinc.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom-pm8008-regulator.c

index da017c1969d0cc2c6347b68c37518ea8a7ab44a3..90c78ee1c37bf9bf69f43e0bb7798fed94590e95 100644 (file)
@@ -96,7 +96,7 @@ static int pm8008_regulator_get_voltage_sel(struct regulator_dev *rdev)
 
        uV = le16_to_cpu(val) * 1000;
 
-       return (uV - preg->desc.min_uV) / preg->desc.uV_step;
+       return regulator_map_voltage_linear_range(rdev, uV, INT_MAX);
 }
 
 static const struct regulator_ops pm8008_regulator_ops = {