net: fix signedness bug in skb_splice_from_iter()

The "len" variable needs to be signed for the error handling to work
correctly.

Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/366861a7-87c8-4bbf-9101-69dd41021d07@kili.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 653abd8a697528a1483f69006a161e9c5bacdd87..7c4338221b173f83f5dbfa53a72bb9f184c00613 100644 (file)
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -6931,8 +6931,8 @@ ssize_t skb_splice_from_iter(struct sk_buff *skb, struct iov_iter *iter,
        unsigned int i;
 
        while (iter->count > 0) {
-               ssize_t space, nr;
-               size_t off, len;
+               ssize_t space, nr, len;
+               size_t off;
 
                ret = -EMSGSIZE;
                space = frag_limit - skb_shinfo(skb)->nr_frags;