]> www.infradead.org Git - users/willy/linux.git/commitdiff
net: qed: remove unneeded return variables
authorJason Wang <wangborong@cdjrlc.com>
Sun, 25 Jul 2021 15:13:53 +0000 (23:13 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Jul 2021 10:55:19 +0000 (11:55 +0100)
Some return variables are never changed until function returned.
These variables are unneeded for their functions. Therefore, the
unneeded return variables can be removed safely by returning their
initial values.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_dcbx.c

index e81dd34a3cac20b960b49a743ab8ec76a2352022..dc93ddea8906bd55723705e3fd352bb43dca39c3 100644 (file)
@@ -741,7 +741,6 @@ static int
 qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
 {
        struct qed_dcbx_mib_meta_data data;
-       int rc = 0;
 
        memset(&data, 0, sizeof(data));
        data.addr = p_hwfn->mcp_info->port_addr + offsetof(struct public_port,
@@ -750,7 +749,7 @@ qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
        data.size = sizeof(struct lldp_config_params_s);
        qed_memcpy_from(p_hwfn, p_ptt, data.lldp_local, data.addr, data.size);
 
-       return rc;
+       return 0;
 }
 
 static int
@@ -810,7 +809,6 @@ static int
 qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
 {
        struct qed_dcbx_mib_meta_data data;
-       int rc = 0;
 
        memset(&data, 0, sizeof(data));
        data.addr = p_hwfn->mcp_info->port_addr +
@@ -819,7 +817,7 @@ qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
        data.size = sizeof(struct dcbx_local_params);
        qed_memcpy_from(p_hwfn, p_ptt, data.local_admin, data.addr, data.size);
 
-       return rc;
+       return 0;
 }
 
 static int qed_dcbx_read_mib(struct qed_hwfn *p_hwfn,