]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
lpfc: fix missing zero termination in debugfs
authorAlan <gnomes@lxorguk.ukuu.org.uk>
Mon, 15 Feb 2016 19:11:56 +0000 (19:11 +0000)
committerChuck Anderson <chuck.anderson@oracle.com>
Wed, 13 Jul 2016 07:44:35 +0000 (00:44 -0700)
If you feed 32 bytes in then the kstrtoull() doesn't receive a terminated
string so will run off the end.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Orabug: 23762058
(cherry picked from commit 0872774d8a319676dea7416e0cf85bec63eea0d0)
Signed-off-by: Manjunath Govindashetty <manjunath.govindashetty@oracle.com>
drivers/scsi/lpfc/lpfc_debugfs.c

index 513edcb0c2dae3794b302282b62a730eeda0c6f5..a051a0c01232f9c193fc83d042fef0bee0ba399e 100644 (file)
@@ -1054,11 +1054,11 @@ lpfc_debugfs_dif_err_write(struct file *file, const char __user *buf,
 {
        struct dentry *dent = file->f_path.dentry;
        struct lpfc_hba *phba = file->private_data;
-       char dstbuf[32];
+       char dstbuf[33];
        uint64_t tmp = 0;
        int size;
 
-       memset(dstbuf, 0, 32);
+       memset(dstbuf, 0, 33);
        size = (nbytes < 32) ? nbytes : 32;
        if (copy_from_user(dstbuf, buf, size))
                return 0;